Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create storefront wishlist page and wishlist tasks #295

Merged
merged 13 commits into from
Feb 11, 2025

Conversation

ocavli
Copy link
Contributor

@ocavli ocavli commented Jan 30, 2025

No description provided.

@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from ce62453 to d2f9626 Compare January 30, 2025 13:16
@ocavli ocavli requested a review from a team January 30, 2025 13:21
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from d2f9626 to 3803c24 Compare January 30, 2025 13:50
@ocavli ocavli changed the title create storefront wishlist page and wishlist tasks feat: create storefront wishlist page and wishlist tasks Jan 30, 2025
@ocavli ocavli self-assigned this Jan 30, 2025
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from 3803c24 to 9291d9e Compare January 31, 2025 15:18
vanpham-sw
vanpham-sw previously approved these changes Feb 3, 2025
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch 2 times, most recently from f3550ac to 9291d9e Compare February 3, 2025 13:17
@ocavli ocavli requested a review from a team February 3, 2025 13:19
Copy link
Contributor

@yusufttur yusufttur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add all three tasks in a single task file instead of three separate files.

src/page-objects/storefront/Home.ts Outdated Show resolved Hide resolved
src/page-objects/storefront/Wishlist.ts Outdated Show resolved Hide resolved
src/tasks/shop-customer/Wishlist/AddProductToWishlist.ts Outdated Show resolved Hide resolved
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from 4621e51 to fb67c27 Compare February 4, 2025 07:18
src/page-objects/storefront/Home.ts Outdated Show resolved Hide resolved
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from 15799d3 to e24169e Compare February 7, 2025 07:55
@ocavli ocavli requested a review from frobel February 10, 2025 10:32
src/page-objects/storefront/Wishlist.ts Outdated Show resolved Hide resolved
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from bbf4366 to 41798dd Compare February 11, 2025 14:29
@ocavli ocavli requested a review from frobel February 11, 2025 14:31
@ocavli ocavli force-pushed the next-40282/create-storefront-wishlist-page branch from 41798dd to 958b52a Compare February 11, 2025 15:06
@frobel frobel merged commit 2a06c23 into trunk Feb 11, 2025
6 checks passed
@frobel frobel deleted the next-40282/create-storefront-wishlist-page branch February 11, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants